[OE-core] [PATCH] core-image-basic.bb: Allow user extensions

[Gary Thomas]

On 2013-10-30 08:47, Paul Eggleton wrote:
> Hi Gary,
>
> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>> Allow the user to provide additional packages to this image.
>> This lets core-image-basic behave like all other core-image*
>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>> as match the documentation which suggests this as the mode to
>> extend any core-image* image.
>>
>> Signed-off-by: Gary Thomas <gary at mlbassoc.com>
>> ---
>>    meta/recipes-extended/images/core-image-basic.bb |    3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>> 100644
>> --- a/meta/recipes-extended/images/core-image-basic.bb
>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>> @@ -3,9 +3,12 @@ functionality installed."
>>     IMAGE_FEATURES += "splash ssh-server-openssh"
>>    +CORE_IMAGE_EXTRA_INSTALL ?= ""
>> +
>
> Not sure if it's my mail client but the above looks slightly mangled; in any
> case the above addition shouldn't be needed because core-image.bbclass already
> does this.

Are you sure it counts?  core-image.bbclass is included after this would be evaluated,
or does that not matter?

>
>>    IMAGE_INSTALL = "\
>>        packagegroup-core-boot \
>>        packagegroup-core-basic \
>> +    ${CORE_IMAGE_EXTRA_INSTALL} \
>>        "
>>     inherit core-image
>
> Good catch on this one though.
>
> Cheers,
> Paul
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------