[OE-core] [PATCH 1/1] glib-2.0: fix a host contamination issue

Tomas Frydrych tf+lists.yocto at r-finger.com
Tue Sep 3 11:39:05 UTC 2013


On 03/09/13 12:16, Robert Yang wrote:
> 
> 
> On 09/03/2013 05:51 PM, Burton, Ross wrote:
>> On 3 September 2013 08:52, Robert Yang <liezhi.yang at windriver.com> wrote:
>>> +    sed -i -e 's/^\(ABS_GLIB_RUNTIME_LIBDIR=.*readlink\) -f/\1 -m/'
>>> ${S}/configure.ac
>>
>> Please do this as a patch instead of a sed.
> 
> It seems that sed command is preferred ? For example, we don't have to
> port the
> patch once we upgrade glib-2.0.

Having to port a patch when it fails to apply ensures we are still doing
the right thing. In contrast, these sed snippets don't generate errors
when they fail, and they remain in recipes for years when no longer
working/needed.

Tomas




More information about the Openembedded-core mailing list