[OE-core] [PATCH 2/4] xorg-driver-common: Add configure and install appends from meta-intel

Burton, Ross ross.burton at intel.com
Thu Sep 5 09:53:22 UTC 2013


On 5 September 2013 01:18, Darren Hart <dvhart at linux.intel.com> wrote:
> +# AC_CHECK_FILE doesn't work when cross compiling, so we create a replacement
> +# macro that simply assumes the test succeeds. This is required for at least
> +# the -intel and -mga drivers.
> +do_configure_prepend () {
> +       echo 'AC_DEFUN(CC_AC_CHECK_FILE, $2)' > ${S}/configure.ac.new
> +       sed 's/AC_CHECK_FILE/CC_AC_CHECK_FILE/g' ${S}/configure.ac >> ${S}/configure.ac.new
> +       mv ${S}/configure.ac.new ${S}/configure.ac
> +}

I've been systematically fixing the drivers that use AC_CHECK_FILE so
now as far as I know we're left with just one (-mga), for which my
patch has been submitted upstream.

I'd prefer to see the patch retained and upstream fixed instead of
working around the breakage, because the test that configure.ac is
attempting to do is valid, it's just done wrong.

>+# FIXME: We don't want to include the libtool archives (*.la) from modules
>+# directory, as they serve no useful purpose. Upstream should fix Makefile.am
>+do_install_append() {
>+       find ${D}${libdir}/xorg/modules -regex ".*\.la$" | xargs rm -f --
>+}

Sadly when using libtool you can't "opt-out" of installing .la files
unless you delete the files that just got installed.  In my opinion
this is something that needs to be done globally instead of
per-recipe.

Ross



More information about the Openembedded-core mailing list