[OE-core] [PATCH 1/2] mesa: use distro_features_check to abort build without opengl feature

[Nicolas Dechesne]

On Mon, Sep 9, 2013 at 2:12 PM, Burton, Ross <ross.burton at intel.com> wrote:

> On 9 September 2013 13:08, Martin Jansa <martin.jansa at gmail.com> wrote:
> >> +REQUIRED_DISTRO_FEATURES = "opengl"
> >
> > Is this really needed? I was building mesa in distro without opengl for
> > long time and was considering (probably incorrectly) opengl
> DISTRO_FEATURE more
> > like sign of proper hw GL libraries.
>
> I'd always understood the "opengl" DISTRO_FEATURE to mean "give me GL
> support".  *What* that means depends on the target hardware, could be
> entirely software rendering through Mesa or binary HW drivers.


how about gl vs gles?

i have been trying to understand over the last couple of days whether or
not 'opengl' in DISTRO_FEATURES means OpenGL and OpenGLES. I don't think
it's clearly indicated anywhere.

in libsdl recipe, we have this:

DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '',
d)} \

           ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl',
'', d)} \

and in EXTRA_OECONF we add this:
${@base_contains('DISTRO_FEATURES', 'opengl', '--enable-video-opengl',
'--disable-video-opengl', d)} \


which tends to make me think that 'opengl' means 'OpenGL', not OpenGLES. I
am building for ARM platforms with GLes support, but no GL support. I
initially had 'opengl' in DISTRO_FEATURES, but we ended with mesa being
pulled in because of libsdl, which was wrong. So we now removed 'opengl'
from our DISTRO_FEATURES list. (note we have our own EGL/GLes library for
GPU, so we don't want mesa at all).

In weston recipe, we have this:
${@base_contains('DISTRO_FEATURES', 'opengles2', 'gles', '', d)}

so, that seems to imply that opengles2 is now a 'new' DISTRO_FEATURES, but
it's only used once (looking at oe-core and meta-oe).

To me having 2 different flags for opengl and opengles in DISTRO_FEATURES
does make sense...  but i could be wrong..

what do you think?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130909/602c52ac/attachment-0002.html>