[OE-core] [PATCH 1/1] python: fix failures of LSB python-runtime tests

[Saul Wold]

On 09/15/2013 06:33 PM, Hongxu Jia wrote:
> On 09/16/2013 04:52 AM, Saul Wold wrote:
>> On 09/13/2013 09:31 PM, Hongxu Jia wrote:
>>> It has been fixed in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e261c1760d8a660c13cd00039a4812d51f47f3df
>>>
>>>
>>> But there is a typo in:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
>>>
>>> It missed to remove an extra "--with-wctype-functions" in EXTRA_OECONF
>>>
>>> [YOCTO #5154]
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
>>> ---
>>>   meta/recipes-devtools/python/python.inc | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/python/python.inc
>>> b/meta/recipes-devtools/python/python.inc
>>> index 80609a8..fcfeda5 100644
>>> --- a/meta/recipes-devtools/python/python.inc
>>> +++ b/meta/recipes-devtools/python/python.inc
>>> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
>>>     --with-cyclic-gc \
>>>     --without-cxx \
>>>     --with-signal-module \
>>> -  --with-wctype-functions \
>> I think this needs to be protected with a linuxstdbase check.
>>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=78ac027f2ac6c6663fff7080eabbd3d09c1241bb
> has done this, but missing to remove the extra ' --with-wctype-functions'
>
Sorry, I rushed the review of this and did not look at the big picture. 
  Your patch seems correct.

Sau!

> inherit autotools
>
> +PYTHONLSBOPTS = "--with-wctype-functions"
> +PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
> +
>   EXTRA_OECONF = "\
>     --with-threads \
>     --with-pymalloc \
> @@ -24,14 +27,5 @@ EXTRA_OECONF = "\
>     --with-signal-module \
>     --with-wctype-functions \
>     --enable-shared \
> -"
> -
> -EXTRA_OECONF_linuxstdbase = "\
> -  --with-threads \
> -  --with-pymalloc \
> -  --with-cyclic-gc \
> -  --without-cxx \
> -  --with-signal-module \
> -  --enable-shared \
> -  ac_cv_sizeof_off_t=8 \
> +  ${PYTHONLSBOPTS} \
>   "
>
> //Hongxu
>
>
>
>> Sau!
>>
>>>     --enable-shared \
>>>     --enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes',
>>> 'no', d)} \
>>>     ${PYTHONLSBOPTS} \
>>>
>