[OE-core] [PATCH] perf: Remove CFLAGS and LDFLAGS override

[Otavio Salvador]

On Mon, Sep 16, 2013 at 4:10 AM, Saul Wold <sgw at linux.intel.com> wrote:
> On 09/15/2013 06:37 PM, Otavio Salvador wrote:
>>
>> The kernel build system does the right thing here and we should stop
>> overriding it. This code has been added based on a change from
>> 'meta-metro' layer, revision 9d698004137c1a888d40d6a4808d94afa22387e7,
>> without any information about what problem it fixes so I am reverting
>> it.
>>
>> Using the CFLAGS makes it impossible for kernel build system to append
>> to it, thus making the build fail in various ways as:
>>
>> |     CC /.../perf/1.0-r8/perf-1.0/perf.o
>> | In file included from builtin.h:4:0,
>> |                  from perf.c:9:
>> | util/util.h:74:24: fatal error: lk/debugfs.h: No such file or directory
>> |  #include <lk/debugfs.h>
>> |                         ^
>> | compilation terminated.
>>
>> Cc: Christopher Larson <kergoth at gmail.com>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>   meta/recipes-kernel/perf/perf.bb | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/perf/perf.bb
>> b/meta/recipes-kernel/perf/perf.bb
>> index d2c1048..8d35fc6 100644
>> --- a/meta/recipes-kernel/perf/perf.bb
>> +++ b/meta/recipes-kernel/perf/perf.bb
>> @@ -72,13 +72,7 @@ EXTRA_OEMAKE = \
>>                 NO_GTK2=1 ${TUI_DEFINES} NO_DWARF=1 ${SCRIPTING_DEFINES} \
>>                 '
>>
>> -# We already pass the correct arguments to our compiler for the CFLAGS
>> (if we
>> -# don't override it, it'll add -m32/-m64 itself). For LDFLAGS, it was
>> failing
>> -# to find bfd symbols.
>>   EXTRA_OEMAKE += "\
>> -       'CFLAGS=${CFLAGS} -fPIC' \
>> -       'LDFLAGS=${LDFLAGS} -lpthread -lrt -lelf -lm -lbfd' \
>> -       \
>
> Maybe not, I got a compile error with this on the Autobuilder.
>
> http://autobuilder.yoctoproject.org:8011/builders/nightly-x86-64/builds/286/steps/Building%20Images/logs/stdio

I only reproduce this error if I build with EXTRA_CFLAGS set. There
are no other changes in perf?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750