[OE-core] [v2 PATCH 5/7] bootimage.bbclass, grub-efi.bbclass: Improve EFI & PCBIOS+EFI ISO support
Jason Wessel
jason.wessel at windriver.com
Tue Sep 17 11:08:03 UTC 2013
On 09/16/2013 12:30 PM, Darren Hart wrote:
> On Fri, 2013-09-13 at 19:09 -0500, Jason Wessel wrote:
>> - if [ "${PCBIOS}" = "1" ]; then
>> + # EFI only
>> + if [ "${PCBIOS}" != "1" ] && [ "${EFI}" = "1" ] ; then
>> + mkdir -p ${ISODIR}/${ISOLINUXDIR}
>> + install -m 0644 ${STAGING_DATADIR}/syslinux/isolinux.bin ${ISODIR}${ISOLINUXDIR}
>
> If it's EFI-only, we copy isolinux.bin over? I was under the impression
> isolinux.bin was a PCBIOS thing (specifically an executable that
> wouldn't even work in an EFI environment). How is this used with an
> EFI-only image? What am I missing?
There is a bug/feature in the isohybrid that requires it to be in the catalog. I couldn't figure out how to work around it, so I left it in there. The EFI firmware skips right over it anyway. I can add a comment to the bbclass to this effect.
>
>> + fi
>> +
>> + if [ "${PCBIOS}" = "1" ] && [ "${EFI}" != "1" ] ; then
>> + # PCBIOS only media
>> mkisofs -V ${BOOTIMG_VOLUME_ID} \
>> -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.iso \
>> -b ${ISO_BOOTIMG} -c ${ISO_BOOTCAT} -r \
>> ${MKISOFS_OPTIONS} ${ISODIR}
>> else
>> - bbnote "EFI-only ISO images are untested, please provide feedback."
>> - mkisofs -V ${BOOTIMG_VOLUME_ID} \
>> + # EFI only OR EFI+PCIBIOS
>
> Nit: s/PCIBIOS/PCBIOS/
Oops, all fixed in v3. :-)
Jason.
More information about the Openembedded-core
mailing list