[OE-core] [PATCH] Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb
Paul Eggleton
paul.eggleton at linux.intel.com
Tue Sep 17 13:18:17 UTC 2013
On Tuesday 17 September 2013 14:07:01 Paul Barker wrote:
> On 17 September 2013 12:22, JC <jc at vtkloud.com> wrote:
> > From: JC Verdie <jc.verdie at innotis.org>
> >
> > Signed-off-by: JC Verdie <jc.verdie at innotis.org>
>
> Couple of tips on the commit message:
>
> First line of the commit message should be "libao: add version 1.1.0"
> or similar and should be and fairly short, put the link to the source
> within the body of the commit message and possibly reference the
> author of the recipe you're copying this from if you can.
Right. A few other things:
1) Since nothing in OE-Core needs this at the moment, this should really be
added to meta-multimedia (within the meta-openembedded repository) and sent to
the openembedded-devel mailing list marked with [meta-multimedia] in the
subject.
2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can
work
3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and
possibly also DESCRIPTION if you have a longer description).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
More information about the Openembedded-core
mailing list