[OE-core] [PATCH] perf: Add LDFLAGS to allow build of old kernels without patching

[Bruce Ashfield]

On Wed, Sep 18, 2013 at 9:51 AM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> The LDFLAGS is required or some old kernels fails due missing
> symbols and this is preferred than requiring patches to every old
> supported kernel.
>
> Fixes [YOCTO: #5221]
>

Confirmed here as well, I was able to build my perf tests, and the meta-fsl-ppc
ones have been confirmed in the bug, and with Otavio's confirmation here .. we
should be good to go .. I hope :)

Acked-by: Bruce Ashfield <bruce.ashfield at windriver.com>

Cheers,

Bruce

> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
>  meta/recipes-kernel/perf/perf.bb | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 4a815ff..269069f 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -60,6 +60,11 @@ B = "${WORKDIR}/${BPN}-${PV}"
>  SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
>  TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}"
>
> +# The LDFLAGS is required or some old kernels fails due missing
> +# symbols and this is preferred than requiring patches to every old
> +# supported kernel.
> +LDFLAGS="-ldl -lutil"
> +
>  EXTRA_OEMAKE = \
>                 '-C ${S}/tools/perf \
>                 O=${B} \
> @@ -88,13 +93,13 @@ PARALLEL_MAKE = ""
>
>  do_compile() {
>         # Linux kernel build system is expected to do the right thing
> -       unset CFLAGS LDFLAGS
> +       unset CFLAGS
>         oe_runmake all
>  }
>
>  do_install() {
>         # Linux kernel build system is expected to do the right thing
> -       unset CFLAGS LDFLAGS
> +       unset CFLAGS
>         oe_runmake DESTDIR=${D} install
>         # we are checking for this make target to be compatible with older perf versions
>         if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
> --
> 1.8.4.rc3
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"