[OE-core] [PATCHv2 1/2] trace-cmd/kernelshark: update to 2.3.2 release (latest stable branch)

[Fathi Boudra]

On 9 April 2014 18:02, Chris Larson <clarson at kergoth.com> wrote:
>
> On Tue, Apr 8, 2014 at 10:16 AM, Fathi Boudra <fathi.boudra at linaro.org>
> wrote:
>>
>> On 8 April 2014 20:05, Khem Raj <raj.khem at gmail.com> wrote:
>> > On Tue, Apr 8, 2014 at 7:00 AM, Fathi Boudra <fathi.boudra at linaro.org>
>> > wrote:
>> >>  do_install() {
>> >> -       oe_runmake prefix="${prefix}" DESTDIR="${D}" install
>> >> +       ${MAKE} NO_PYTHON=1 prefix=${prefix}
>> >> plugin_dir=${libdir}/trace-cmd/plugins DESTDIR=${D} install
>> >>  }
>> >
>> > can you explain/document this change
>>
>> sure. trace-cmd doesn't have a build system generated Makefile. It's
>> hand written.
>> To do the install properly, one has to pass prefix/plugin_dir.
>> In addition, the previous command in the recipe doesn't do the right
>> thing anymore (you'll end with duplicated prefix /usr/usr/).
>
>
> You don't need to avoid the use of oe_runmake to pass variables in, that's
> what EXTRA_OEMAKE is for :) See
> https://github.com/MentorEmbedded/meta-mentor/commit/4639877 for a version
> of this fix that uses it instead.

You don't need oe_runmake or EXTRA_OEMAKE to properly build and
install the files in the right path either :)
You can even drop inherit pkgconfig pythonnative since they aren't
used. My version is also slightly shorter to achieve the same goal.

All in all, I don't mind which version is taken as long as we update
the one in oe-core.

Cheers,
Fathi