[OE-core] [oe-core][PATCH 2/2] systemd: fix tests when not using gold

Khem Raj raj.khem at gmail.com
Thu Apr 24 02:37:53 UTC 2014


On Wed, Apr 23, 2014 at 9:43 AM, Dan McGregor <danismostlikely at gmail.com> wrote:
> On 23 April 2014 10:34, Saul Wold <sgw at linux.intel.com> wrote:
>>
>> On 04/23/2014 08:01 AM, Dan McGregor wrote:
>>>
>>> From: Dan McGregor <dan.mcgregor at usask.ca>
>>>
>>> Explicitly mark the dummy function as externally visible
>>> so that ld can find the symbol at link time. This is needed
>>> when the DISTRO_FEATURE ld-is-gold is not enabled; systemd
>>> uses -flto anyway.
>>>
>>> Signed-off-by: Dan McGregor <dan.mcgregor at usask.ca>
>>> ---
>>>   meta/recipes-core/systemd/systemd/systemd-lto-fix.patch | 14
>>> ++++++++++++++
>>>   meta/recipes-core/systemd/systemd_211.bb                |  1 +
>>>   2 files changed, 15 insertions(+)
>>>   create mode 100644
>>> meta/recipes-core/systemd/systemd/systemd-lto-fix.patch
>>>
>>> diff --git a/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch
>>> b/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch
>>> new file mode 100644
>>> index 0000000..90875e4
>>> --- /dev/null
>>> +++ b/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch
>>
>>
>> The patch also needs an appropriate Upstream-Status and Signed-off-by tags
>> here.
>>
>> Thanks
>>         Sau!
>>
>
> As I said to Ross off-list (accidentally), this patch was for Linaro GCC as
> of 2014-03-20. I'm going to check that it's still vald, and if so I'll send
> it upstream too.

FWIW, I have updated the systemd recipe to 212+ its here
http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=f4283b924c13ea4d98b4251e11dd6a3388f195d5

can you check if this patch is still needed there ? I use gold/arm and
did not run into this issue.

>
> Thanks,
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



More information about the Openembedded-core mailing list