[OE-core] [PATCH 1/3] alsa-lib: use get32_labels for multi-source

Otavio Salvador otavio at ossystems.com.br
Mon Aug 4 20:13:38 UTC 2014


On Mon, Aug 4, 2014 at 12:21 AM, Wang Zidan <b50113 at freescale.com> wrote:
> The PCM route plugin can assign the destination value from average of
> multiple sources with attenuation. This requires the read of each
> channel value, sums and writes the resultant value in the requested
> format.
>
> get_labels gives the value as is only with endianness and signedness
> conversions, but put32_labels assumes that the value is normalized to
> 32bit int and it shifts down to the dest format. In addition, the
> current code lacks get_labels entries for the 24bit formats.
>
> For fixing these bugs, this patch replaces the read with get32_labels
> and use always 64bit int for sum.
>
> Signed-off-by: Wang Zidan <b50113 at freescale.com>

Acked-by: Otavio Salvador <otavio at ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list