[OE-core] [PATCH 1/2] logrotate: obey our flags

Usman, Fahad Fahad_Usman at mentor.com
Tue Aug 26 07:43:38 UTC 2014


On 08/25/2014 10:51 PM, Khem Raj wrote:
>>>> +    LFS= \
>>>> > > >+    OS_NAME='${OS_NAME}' \
>>>> > > >+    \
>>>> > > >+    'CC=${CC}' \
>>> > >
>>> > >hmmm CC may have spaces in it so you might need 'CC="${CC}"' or somesuch
>> >
>> >
>> >Nope, the whole CC=${CC} argument is already quoted, note the single quotes
>> >around it. Those quotes mean the entire CC=${CC} bit ends up in the
>> >appropriate argument for make, so there's no need to quote the value alone.
> What happens inside makefile is what I am concerned
> in case of python, IIRC it passed it but when CC was used it would
> freak out since CC now was a multiword str but then those were not inside makefiles
> if you have verified thats fine here then I am OK.
Just checked the CC do have spaces, and it works fine. I am re-sending 
the patch with the fixed typo.



More information about the Openembedded-core mailing list