[OE-core] [PATCH 1/4] base.bbclass: fix CLEANBROKEN logic

Ross Burton ross.burton at intel.com
Thu Dec 4 14:21:07 UTC 2014


The evalation order was incorrect in some situations (CLEANBROKEN=1 and
GNUmakefile exists) the clean would be executed incorrectly.

Add brackets to correct the logic.

Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/base.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index f3185b4..de81a7d 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -226,7 +226,7 @@ base_do_configure() {
 	if [ -n "${CONFIGURESTAMPFILE}" -a -e "${CONFIGURESTAMPFILE}" ]; then
 		if [ "`cat ${CONFIGURESTAMPFILE}`" != "${BB_TASKHASH}" ]; then
 			cd ${B}
-			if [ "${CLEANBROKEN}" != "1" -a -e Makefile -o -e makefile -o -e GNUmakefile ]; then
+			if [ "${CLEANBROKEN}" != "1" -a \( -e Makefile -o -e makefile -o -e GNUmakefile \) ]; then
 				${MAKE} clean
 			fi
 			find ${B} -name \*.la -delete
-- 
1.7.10.4




More information about the Openembedded-core mailing list