[OE-core] [RFC PATCH 0/7] Developer workflow improvements

[Otavio Salvador]

On Thu, Dec 11, 2014 at 7:35 PM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> On Thursday 11 December 2014 14:43:40 Trevor Woerner wrote:
>> On 12/11/14 14:16, Trevor Woerner wrote:
>> > Oops! (this worked before the "git pull")
>> >
>> >     $ devtool add xannounce ~/devel/yocto/build/workflow/xannounce/
>> >     NOTE: Creating workspace layer in
>> >     /home/trevor/devel/yocto/build/workflow/build/workspace
>> >     NOTE: Recipe
>> >     /home/trevor/devel/yocto/build/workflow/build/workspace/recipes/xannou
>> >     nce/xannounce.bb has been automatically created; further editing may
>> >     be required to make it fully functional
>> >
>> >     Traceback (most recent call last):
>> >       File
>> >
>> >     "/home/trevor/devel/yocto/build/workflow/meta-poky/scripts/devtool",
>> >     line 274, in <module>
>> >
>> >         ret = main()
>> >
>> >       File
>> >
>> >     "/home/trevor/devel/yocto/build/workflow/meta-poky/scripts/devtool",
>> >     line 267, in main
>> >
>> >         ret = args.func(args, config, basepath, workspace)
>> >
>> >       File
>> >
>> >     "/home/trevor/devel/yocto/build/workflow/meta-poky/scripts/lib/devtool
>> >     /standard.py", line 68, in add
>> >
>> >         _add_md5(config, args.recipename, recipefile)
>> >
>> >       File
>> >
>> >     "/home/trevor/devel/yocto/build/workflow/meta-poky/scripts/lib/devtool
>> >     /standard.py", line 218, in _add_md5
>> >
>> >         md5 = bb.utils.md5_file(filename)
>> >
>> >       File
>> >
>> >     "/home/trevor/devel/yocto/build/workflow/meta-poky/bitbake/lib/bb/util
>> >     s.py", line 463, in md5_file
>> >
>> >         with open(filename, "rb") as f:
>> >     IOError: [Errno 2] No such file or directory:
>> >     '/home/trevor/devel/yocto/build/workflow/build/workspace/recipes/xanno
>> >     unce/xannounce.bb'>
>> > Sure enough...
>> >
>> >     $ devtool-workflow> tree workspace/
>> >     workspace/
>> >
>> >     |-- appends
>> >     |-- conf
>> >     |
>> >     |   `-- layer.conf
>> >
>> >     `-- recipes
>> >
>> >         `-- xannounce
>> >
>> >     4 directories, 1 file
>> >
>> > whereas before it was:
>> >     $ tree workspace/
>> >     workspace/
>> >
>> >     |-- appends
>> >     |
>> >     |   `-- xannounce.bbappend
>> >     |
>> >     |-- conf
>> >     |
>> >     |   `-- layer.conf
>> >
>> >     `-- recipes
>> >
>> >         `-- xannounce
>> >
>> >             `-- xannounce.bb
>> >
>> >     4 directories, 3 files
>> >
>> > For some reason my recipe and bbappends are not getting created :-(
>>
>> bisecting (manually) leads to this commit being safe:
>>
>> ea50ec527483eb3a094588858baebd5fb23f71c6 devtool: rename deploy/undeploy
>> to deploy-target/undeploy-target
>>
>> and this one introducing the problem:
>>
>> 770f203f73f358ce3c6c5ac12fe2775b812bdc6b devtool: fool bitbake into
>> thinking it's outputting to a terminal
>
> Thanks for the quick bisect - I've fixed it so that wrapper is only used when
> running bitbake through "devtool build", and now "devtool add" works properly
> again. This is why I should probably write some proper tests before trying to
> do anything further...

Agreed. I think a good unittest needs to be include sooner than later
as the more it grows, the harder will be to cover all usecases with
tests.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750