[OE-core] [PATCH] [NEEDS TESTING] opkg: Fix add-exclude.patch

Paul Barker paul at paulbarker.me.uk
Tue Feb 11 11:32:34 UTC 2014


On 27 January 2014 12:44, Paul Barker <paul at paulbarker.me.uk> wrote:
> The case statement for ARGS_OPT_ADD_EXCLUDE added to the argument handling
> switch statement in opkg was missing a "break;" at the end, so it was falling
> through into the handler for ARGS_OPT_NOACTION. Thus when "--add-exclude" was
> specified on the command line it was as if "--noaction" was also being
> specified. This appears to be the root cause of YP bug 5311.
>
> This patch should fix that behaviour and that bug.
>
> Signed-off-by: Paul Barker <paul at paulbarker.me.uk>
> Cc: Mark Hatle <mark.hatle at windriver.com>
> Cc: Saul Wold <saul.wold at intel.com>

I should have checked this more myself before sending - I didn't run
'rediff' on the patch after manually editing it so it failed to apply
cleanly. I'll update it and send v2.

I'm still not sure how best to test this one myself but it would be
good to see it tested and fix the relevant bug. Once that's done I can
look at upstreaming this feature into opkg.

-- 
Paul Barker

Email: paul at paulbarker.me.uk
http://www.paulbarker.me.uk



More information about the Openembedded-core mailing list