[OE-core] [PATCH 3/3] flac: upgrade to 1.3.0

[Iorga, Cristian]

Hello Ross, all,

Thanks for the review.
Will correct the typo.

>                  --without-xmms-prefix \
>                  --without-xmms-exec-prefix \

To me it seems that this are still necessary, as it prevents from looking for an existent xmms player.
So I left those in.
I will try and if no adverse effect is seen, I will remove those also.

Regards,
Cristian Iorga
YP
Intel Corporation


-----Original Message-----
From: Burton, Ross [mailto:ross.burton at intel.com] 
Sent: Wednesday, February 12, 2014 12:32 PM
To: Iorga, Cristian
Cc: OE-core
Subject: Re: [OE-core] [PATCH 3/3] flac: upgrade to 1.3.0

On 12 February 2014 07:41, Cristian Iorga <cristian.iorga at intel.com> wrote:
> - Updated description, bugtracker and source;
> - Switched to ${BP} variable;
> - 0001-No-AltiVec-on-SPE.patch,
> flac-gcc43-fixes.patch, asm-pic.patch, obsolete_automake_macros.patch 
> patches removed, included in upstream;
> - Licenses checksums changed due to added copyright owners and street 
> adresses changed;
> - backported 1.3.0 specific fix;
> - removed obsolete PPC fix;
> - added support for SSE optimizations.

Got to love a patch that is 90% removals!

> +DESCRIPTION = "FLAC stands for Free Lossless Audio Codec, a losless audio compression format."

"losless" is a typo.

>  S = "${WORKDIR}/flac-${PV}"

This is the default so you can remove this.

> +                --disable-xmms-plugin \
>                  --without-xmms-prefix \
>                  --without-xmms-exec-prefix \

Does the addition of --disable mean you can remove the two --without arguments?

Ross