[OE-core] [PATCH] grub git: workaround debugedit problems for 64 bit targets

[Koen Kooi]

Op 12 feb. 2014, om 09:31 heeft Richard Purdie <richard.purdie at linuxfoundation.org> het volgende geschreven:

> On Wed, 2014-02-12 at 09:03 +0100, Koen Kooi wrote:
>> On 01/15/2014 11:15 AM, Koen Kooi wrote:
>>> I've limited it to 64bit targets, but to be honest debug splitting doesn't make sense for grub since it won't run in your rootfs and attaching gdb is pretty much impossible.
>>> 
>>> Signed-off-by: Koen Kooi <koen.kooi at linaro.org>
>>> ---
>>>  meta/recipes-bsp/grub/grub_git.bb | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>> 
>>> diff --git a/meta/recipes-bsp/grub/grub_git.bb b/meta/recipes-bsp/grub/grub_git.bb
>>> index 1796e7f..bc79cfa 100644
>>> --- a/meta/recipes-bsp/grub/grub_git.bb
>>> +++ b/meta/recipes-bsp/grub/grub_git.bb
>>> @@ -51,8 +51,13 @@ do_configure_prepend() {
>>>  do_install_append () {
>>>      install -d ${D}${sysconfdir}/grub.d
>>>      install -m 0755 ${WORKDIR}/40_custom ${D}${sysconfdir}/grub.d/40_custom
>>> +
>>>  }
>>> 
>>> +# debugedit chokes on 64 bit platforms
>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_aarch64 = "1"
>>> +INHIBIT_PACKAGE_DEBUG_SPLIT_x86-64 = "1"
>>> +
>>>  RDEPENDS_${PN} = "diffutils freetype"
>>>  FILES_${PN}-dbg += "${libdir}/${BPN}/*/.debug"
>>> 
>>> 
>> 
>> Since the package.bbclass change went in yesterday: ping
> 
> Should we just do this for 64 bit targets or should we be doing it
> unconventionally?

It is needed for every 'bare metal' binary we run through debugedit. But for some reason debugedit doesn't choke on 32bit binaries. I'm not sure what the right answer is here, I only fixed it for the archs I ran into problems myself. 

I'd be happy to respin this patch if you let me know what the preferred solution is.

regards,

Koen