[OE-core] [PATCH] kernel-yocto.bbclass: Force do_diffconfig depends to ${PN}
Nathan Rossi
nathan.rossi at xilinx.com
Fri Feb 21 05:37:31 UTC 2014
Commit 07e59b5ff659bde6e6a60c4781c0a2deb406c667 added the task
dependency of 'virtual/kernel:do_kernel_configme' for the do_diffconfig
task. This dependency is only valid for linux recipes that inherit
kernel-yocto (e.g. linux-yocto), however due to virtual/kernel being a
virtual dependency it may not be providing a kernel which inherits
kernel-yocto in which case the do_kernel_configme task might not exist.
In the case where virtual/kernel is provided by a non kernel-yocto
recipe an error is thrown in relation to the dependency, e.g.
ERROR: Task do_diffconfig in linux-yocto-tiny_3.8.bb depends
upon non-existent task do_kernel_configme in linux.bb
Changing the dependency to use '${PN}:do_kernel_configme' forces the
dependency to only depend on the recipe which inherits
kernel-yocto.bbclass.
Signed-off-by: Nathan Rossi <nathan.rossi at xilinx.com>
---
This effects the linux-xlnx recipe in meta-xilinx, causing the above error to be
shown when building the linux-xlnx recipe with PREFERRED_PROVIDER_virtual/kernel
= "linux-xlnx".
I am not sure if this change is entirely correct, there may be a reason for the
dependence on virtual/kernel that I am not aware of, In which case I have cc'd
all parties involved in the commit which added this dependency.
I did however do a test of the diffconfig feature with this dependency change
in place, no regressions are apparent with the linux-yocto recipe.
---
meta/classes/kernel-yocto.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index fab5d4c..ad80621 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -412,4 +412,4 @@ OE_TERMINAL_EXPORTS += "GUILT_BASE KBUILD_OUTPUT"
GUILT_BASE = "meta"
KBUILD_OUTPUT = "${B}"
-do_diffconfig[depends] += "virtual/kernel:do_kernel_configme"
+do_diffconfig[depends] += "${PN}:do_kernel_configme"
--
1.7.9.5
More information about the Openembedded-core
mailing list