[OE-core] [PATCH] conf/bitbake.conf: default HOMEPAGE to blank instead of unknown

[Richard Purdie]

On Tue, 2014-01-21 at 22:39 +0000, Paul Eggleton wrote:
> On Tuesday 21 January 2014 22:23:18 Richard Purdie wrote:
> > On Tue, 2014-01-21 at 12:17 +0000, Paul Eggleton wrote:
> > > The default value for HOMEPAGE of "unknown" has been in place since the
> > > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > > not a valid URL and it just means we have to explicitly check for this
> > > hardcoded string if we're displaying the value in some form of UI, such
> > > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > > check for this value, presumably on the assumption that the recipe will
> > > explicitly set it to "" if there really isn't a homepage, but looking at
> > > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > > convention for some time (with one exception in the latter) and it's
> > > rather uncommon these days to have no URL to associate with a recipe.
> > > 
> > > Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
> > > ---
> > > 
> > >  meta/conf/bitbake.conf | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > index 57668e1..4fb6a1c 100644
> > > --- a/meta/conf/bitbake.conf
> > > +++ b/meta/conf/bitbake.conf
> > > @@ -241,7 +241,7 @@ This package contains documentation."
> > > 
> > >  LICENSE = "INVALID"
> > >  MAINTAINER = "OE-Core Developers
> > >  <openembedded-core at lists.openembedded.org>"> 
> > > -HOMEPAGE = "unknown"
> > > +HOMEPAGE = ""
> > 
> > Perhaps we just shouldn't set it at all in bitbake.conf and let recipes
> > elect to set it?
> 
> Maybe, but I think that alone isn't necessarily enough because then converting 
> the value to a string gives you "None" (and this is what happens with the rpm 
> backend).

Lets fix the rpm backend then ;-)

Cheers,

Richard