[OE-core] [PATCH] boot-directdisk: fix the support of vmdk

[Otavio Salvador]

On Thu, Jan 23, 2014 at 4:50 AM, Saul Wold <sgw at linux.intel.com> wrote:
> From: Joao Henrique Ferreira de Freitas <joaohf at gmail.com>
>
> Previous change (086ce22b88f5ef5f75a83119a32c8b3fdcfa296d) broke
> the creating of vmdk images. This protects shell expansion variables
> and let dd generate the image to be transformed to vmdk by image-vmdk.class.
>
> Signed-off-by: Joao Henrique Ferreira de Freitas <joaohf at gmail.com>
>
> [edit to change the usage of IMAGE_FSTYPE to IS_VMDK]
>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>

This is hard to review as it has two mixed changes.

It changes the IS_VMDK change and logical changes inside same patch.
Please split it in two patches.

Shell checking for true and false is Bash specific.

$ if [ false ]; then echo "Is true"; else echo "Is false"; fi
Is true

So this does not work with Dash. Please use IMAGE_FSTYPE = "vmdk" for
easy reading of the code.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750