[OE-core] [PATCH] lz4: actually install things

Paul Eggleton paul.eggleton at linux.intel.com
Thu Jan 23 11:46:55 UTC 2014


On Thursday 23 January 2014 09:36:09 Otavio Salvador wrote:
> On Thu, Jan 23, 2014 at 9:35 AM, Koen Kooi <koen at dominion.thruhere.net>
> wrote:
> > Op 23 jan. 2014, om 12:31 heeft Otavio Salvador <otavio at ossystems.com.br>
> het volgende geschreven:
> >> On Thu, Jan 23, 2014 at 7:06 AM, Koen Kooi <koen.kooi at linaro.org> wrote:
> >>> This failure was masked by having lz4 installed on the host system :(
> >>> 
> >>> Signed-off-by: Koen Kooi <koen.kooi at linaro.org>
> >> 
> >> Couldn't it inherit autotools?
> > 
> > It's a handcrafted Makefile, not autotools :(
> 
> No problem, it works as well.
> 
> The do_configure checks for configure.ac/configure.in and it avoid you
> to handcraft do_install and like.

Do _not_ inherit autotools if the software being built doesn't use 
autoconf/automake. Whilst it may work now in some situations, there's 
absolutely no guarantee it won't break in the future. autotools.bbclass needs 
to be able to assume it's actually being used with autotools.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the Openembedded-core mailing list