[OE-core] [PATCH] buildhistory.bbclass: Improve robustness in image file listing

Otavio Salvador otavio at ossystems.com.br
Tue Jan 28 01:52:58 UTC 2014


On Mon, Jan 27, 2014 at 7:52 PM, Randy MacLeod
<randy.macleod at windriver.com> wrote:
> On 14-01-23 07:11 AM, Otavio Salvador wrote:
>>
>> The filenames sometimes may have strange names. With the 'awk' script
>> it handled a limited number of spaces in the filename and a package
>> installing a file named "test file with spaces" would have its name
>> truncated.
>>
>> This patch uses the find's printf formating to simplify the code and
>> proper handle this case. From a testing image, the only diff produced
>
> s/proper/properly/
>   Yes, I'm with the grammar police; we're here to be helpful.
>
>> is:
>>
>> ,----[ files-in-image.txt diff ]
>> | --rwxr-xr-x root       root                0 ./usr/bin/test\ file\ with\
>> | +-rwxr-xr-x root       root                0 ./usr/bin/test file with
>> spaces
>> `----
>>
>> The options used are available since findutils 4.2.5, released in 19
>> Nov 2004, making it available in all supported host distributions.
>
>
> Acked-by: Randy MacLeod <Randy.MacLeod at windriver.com>
>
> Works for me, even on CentOS/RHEL-5.9/10 which does indeed have
> findutils > 4.2.5:
>
> $ rpm -qf `which find`
> findutils-4.2.27-6.el5
>
> and the find command seems to work as intended:
>
>  $ find jj -printf "%M %-10u %-10g %10s %p -> %l\n"  | cut -c 44-
>  jj ->
>  jj/usr ->
>  jj/usr/bin ->
>  jj/usr/bin/test file with spaces ->

Richard, do you want me to send a v2 or can you fix the typo when applying it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list