[OE-core] [PATCH v2 2/2] populate_sdk_base: ensure that filenames with empty space character are handled

Otavio Salvador otavio at ossystems.com.br
Tue Jul 15 13:33:44 UTC 2014


On Mon, Jul 14, 2014 at 7:55 PM, João Henrique Ferreira de Freitas
<joaohf at gmail.com> wrote:
> When extracting toolchain, if the list $executable_files has filenames
> with empty space character, the list will created but relocate_sdk.sh
> will not handle it well. This will lead to the below erro:
>
>     ./tmp/deploy/sdk/buildtools-mytools-x86_64-nativesdk-standalone-1.6.1.0.sh
>     Enter target directory for SDK (default: /opt/mydistro/mytoolset/1.6.1.0):
>     You are about to install the SDK to "/opt/mydistro/mytoolset/1.6.1.0". Proceed[Y/n]?
>     Extracting SDK...done
>     Setting it up.../opt/mydistro/mytoolset/1.6.1.0/relocate_sdk.sh: line 2: sintaxe error `token'  `('
>     /opt/mydistro/mytoolset/1.6.1.0/relocate_sdk.sh: line 2: `e
>
> The same occurs with replacement of ${SDKPATH} in configs/scripts/etc files.
>
> We should ensure that full path is protected before relocate_sdk.sh
> and ${SDKPATH} replacement calls.
>
> Signed-off-by: João Henrique Ferreira de Freitas <joaohf at gmail.com>

I am wondering if we cannot get rid of the 'tr' command that converts
newlines to '\0'. This would avoid a new fork of command. Did you
think about it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list