[OE-core] [PATCH v2] libav: add PACKAGECONFIG for theora, libvorbis, speex and openssl
Matthieu CRAPET
Matthieu.CRAPET at ingenico.com
Tue Jul 15 14:38:05 UTC 2014
Hi Andreas,
Thanks for contribution. Your way is simple but user must know internal dependencies between codecs in licenses.
I think we can drop the GPL v2/v3 case because it is only used with libopencore & libvo that we don't use them in our recipe.
I'll post a v3 patch asap.
Regards,
Matthieu
-----Message d'origine-----
De : openembedded-core-bounces at lists.openembedded.org [mailto:openembedded-core-bounces at lists.openembedded.org] De la part de Andreas Oberritter
Envoyé : vendredi 11 juillet 2014 14:44
À : openembedded-core at lists.openembedded.org
Objet : Re: [OE-core] [PATCH v2] libav: add PACKAGECONFIG for theora, libvorbis, speex and openssl
Hi Matthieu,
I used a different approach, but could't test with master yet.
http://git.openembedded.org/openembedded-core-contrib/commit/?h=obi/daisy&id=1e3c64a768a5aeaf8d904609a14dd29e298821df
While at it, you may also take a look at this commit:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=obi/daisy&id=1e39f95927b65c7943c8d6c36203b8b55c9b3cdf
Feel free to modify and submit as you like.
Regards,
Andreas
On 11.07.2014 13:47, Matthieu CRAPET wrote:
> Hi Koen,
>
> Something like this (in a small python function) would be acceptable?
>
> d.setVar('LICENSE', 'CLOSED')
>
> Regards,
> Matthieu
>
>
> -----Message d'origine-----
> De : Koen Kooi [mailto:koen at dominion.thruhere.net]
> Envoyé : vendredi 11 juillet 2014 08:37 À : Martin Jansa Cc : Matthieu
> CRAPET; openembedded-core at lists.openembedded.org
> Objet : Re: [OE-core] [PATCH v2] libav: add PACKAGECONFIG for theora,
> libvorbis, speex and openssl
>
> [...]
>
>>> +# Check codecs that require --enable-nonfree USE_NONFREE =
>>> +"${@bb.utils.contains_any('PACKAGECONFIG', [ 'faac', 'openssl' ], 'yes', '', d)}"
>>>
>>> EXTRA_OECONF = " \
>>> --enable-shared \
>>> --enable-pthreads \
>>> --enable-gpl \
>>> + ${@bb.utils.contains('USE_NONFREE', 'yes', '--enable-nonfree',
>>> + '', d)} \
>>
>> cannot you just pass --enable-nonfree in faac and openssl PACKAGECONFIG?
>> In worse case when both are enabled the option will be added twice.
>
> If you have nonfree enabled, you need to change the license as well, it won't be GPL anymore.
>
> regards,
>
> Koen
>
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core at lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
More information about the Openembedded-core
mailing list