[OE-core] [PATCH] pixbufcache: Add missing dependency on jpeg-native

[Jacob Kroon]

On Mon, Jul 21, 2014 at 6:00 PM, Jacob Kroon <jacob.kroon at gmail.com> wrote:

> Hi Ross,
>
>
> On Mon, Jul 21, 2014 at 2:49 PM, Burton, Ross <ross.burton at intel.com>
> wrote:
>
>> On 21 July 2014 13:39, Jacob Kroon <jacob.kroon at mikrodidakt.se> wrote:
>> > gdk-pixbuf-native uses png and jpeg loaders. When updating the
>> > loader-cache, these needs to be already populated in the sysroot.
>> >
>> > Although png was present, the jpeg dependency was missing, so add it.
>>
>> But those dependencies are dependent on a PACKAGECONFIG setting, so
>> you'll potentially be forcing a build of libjpeg purely to satisfy a
>> fetch from sstate of a JPEG-disabled gdk-pixbuf.  Also, libtiff and
>> libjasper are missing.
>>
>> If we can't change the sysroot creation order so that the order is
>> zlib, libpng, libjpeg, and then gdk-pixbuf then I think this needs to
>> be pulled out to a function that can do neater logic, such as iterate
>> through PACKAGECONFIG and add the required dependencies (for each
>> enabled option, turn the build depends into
>> %s-native:do_populate_sysroot_setscene).
>>
>>
> What about something like the patch below. It looks at the package's
> DEPENDS,
> and for native packages just adds them to
>
> do_populate_sysroot[depends]
> do_populate_sysroot_setscene[depends]
>
>
Thinking some more about it I don't see this working either, since it only
guarantees 1-level-of-dependencies to be populated, right ?
Wouldn't the right thing here be to somehow postpone updating the
loader-caches until the entire sysroot is populated ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140721/24c228ef/attachment-0002.html>