[OE-core] [PATCH 6/8] lttng-modules: re-enable ARM builds

[Bruce Ashfield]

On Fri, Jul 25, 2014 at 5:53 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Thu, Jul 24, 2014 at 11:10:50PM -0400, Bruce Ashfield wrote:
>> On Thu, Jul 24, 2014 at 6:02 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>> > On Thu, Jul 24, 2014 at 04:41:52PM -0400, Bruce Ashfield wrote:
>> >> With lttng 2.4.2 and gcc 4.9, we can now enable lttng-modules for ARM.
>> >>
>> >> Signed-off-by: Bruce Ashfield <bruce.ashfield at windriver.com>
>> >> ---
>> >>  meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb | 3 +--
>> >>  1 file changed, 1 insertion(+), 2 deletions(-)
>> >>
>> >> diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
>> >> index 5a99a5adae8b..d87374163556 100644
>> >> --- a/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
>> >> +++ b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
>> >> @@ -12,8 +12,7 @@ inherit module
>> >>
>> >>  SRCREV = "789fd1d06d07aeb9a403bdce1b3318560cfc6eca"
>> >>
>> >> -# lttng currently blacklists arm with gcc-4.8
>> >> -COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
>> >> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips|arm).*-linux'
>> >
>> > Please squash this to 2/8 otherwise there is no arm version between 2/8
>> > and 6/8.
>>
>> I'd rather not, since they are separate activities. I updated to 2.5,
>> and then enable
>> ARM. One isolated change per commit. Bisectability in a small series is one
>> thing, but also is the isolation of changes.
>
> 2/8 commit message says:
>
> We also drop the older 2.3.3 lttng-modules, since it is no longer
> required to support ARM builds.
>
> Which isn't true at that time and it means that these changes aren't
> separate activities.
>
> To keep them separate, remove 2.3.3 in this commit, not in upgrade to
> 2.5.0. (or with more work involved, enable arm in 2.4* together with
> 2.3.3 removal as someone reported arm+2.4* also working now).

That'll work, but not on tap for me today. I've got a whole set of backed up
change behind my 3.16 work.

If Richard or Saul care,  won't object to any splitting or squashing they
want to do.

Bruce

>
>> Richard can squash on merge is he wants, but I'm going to leave it as is.
>>
>> Bruce
>>
>> >
>> >>  SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.5 \
>> >>             file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch \
>> >> --
>> >> 1.8.1.2
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core at lists.openembedded.org
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >
>> > --
>> > Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core at lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >
>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end"
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"