[OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

Richard Purdie richard.purdie at linuxfoundation.org
Tue Jun 3 10:58:15 UTC 2014


On Tue, 2014-06-03 at 17:20 +0800, ChenQi wrote:
> The use of alloca() was introduced by an oe-specific patch from Khem Raj.
> 
> The patch is 
> meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch.
> The upstream status of the above patch is as following.
>         Upstream-Status: Denied [no desire for uclibc support]
> 
> That's why I use 'Inappropriate [oe specific]' in the Upstream-Status 
> field of my patch.
> 
> And I just realized I forgot to also patch the journald-kmsg.c file. 
> I'll send out a V2.

Please just update that patch then rather than patching code that we've
ready patched. Is this issue uclibc specific?

At the very least information like this needs to be put into the commit
message/patch header.

Cheers,

Richard




More information about the Openembedded-core mailing list