[OE-core] [PATCH 1/4] libav: add PACKAGECONFIG for theora, libvorbis, speex and openssl

[Matthieu CRAPET]

Saul,

> bb.utils.contains_any() instead of your contains_one implementation.

It is different, that's why I have added it.

+# Check codecs that require --enable-nonfree
+USE_NONFREE = "${@contains_one('PACKAGECONFIG', [ 'faac', 'openssl' ], d)}"

contains_any will not work if PACKAGECONFIG have only one item (faac for example).

Should it be a possible addition to bitbake ?

Matthieu


-----Message d'origine-----
De : Saul Wold [mailto:sgw at linux.intel.com] 
Envoyé : lundi 2 juin 2014 17:31
À : Matthieu CRAPET; openembedded-core at lists.openembedded.org
Objet : Re: [OE-core] [PATCH 1/4] libav: add PACKAGECONFIG for theora, libvorbis, speex and openssl

On 06/02/2014 12:03 AM, Matthieu CRAPET wrote:
> Hi,
>
> Should I rebase/repost this? Aside libav versions/pinning preferences, this single patch deserves to be commited.
>
Yes please, but I think you want to consider using
bb.utils.contains_any() instead of your contains_one implementation.

Sau!

> Regards,
> Matthieu
>
>
> -----Message d'origine-----
> De : openembedded-core-bounces at lists.openembedded.org 
> [mailto:openembedded-core-bounces at lists.openembedded.org] De la part 
> de Matthieu Crapet Envoyé : mercredi 21 mai 2014 13:38 À : 
> openembedded-core at lists.openembedded.org
> Objet : [OE-core] [PATCH 1/4] libav: add PACKAGECONFIG for theora, 
> libvorbis, speex and openssl
>
> Dropped libvorvis dependency because there is already a (better) builtin vorbis codec.
> Don't confuse codec names: "vorbis" (builtin) and "libvorbis" (using external library).
>
> Changes:
> - add --enable-nonfree when faac or openssl are used
> - add DESCRIPTION
> - sort PACKAGECONFIG entries
>
> Tested with libav-0.8.11 & libav-9.13.
>
> Signed-off-by: Matthieu Crapet <Matthieu.Crapet at ingenico.com>
> ---
>   meta/recipes-multimedia/libav/libav.inc | 39 ++++++++++++++++++++++++++-------
>   1 file changed, 31 insertions(+), 8 deletions(-)
>
> [...]
>