[OE-core] cmake: respect ${S} and ${B} patch problem
Miroslav Keš
miroslav.kes at gmail.com
Fri Jun 13 16:51:51 UTC 2014
On 06/13/14 18:38, Burton, Ross wrote:
> On 13 June 2014 17:33, Miroslav Keš <miroslav.kes at gmail.com> wrote:
>> + if [ -z "${OECMAKE_SOURCEPATH}" ]; then
>> + OECMAKE_SOURCEPATH="${S}"
>> fi
>>
>> if [ "${S}" != "${B}" ]; then
>> @@ -84,7 +88,7 @@ cmake_do_configure() {
>>
>> cmake \
>> ${OECMAKE_SITEFILE} \
>> - ${S} \
>> + ${OECMAKE_SOURCEPATH} \
> A better idiom that's more self-documenting would be to set
> OECMAKE_SOURCEPATH ?= "${S}" at the top-level.
You are right.
> Would it be sensible to give that variable a different name as it
> refers specifically to the location of the cmake file, and not the
> rest of the source?
I was thinking about a better name too.
The reason why I stayed with the OECMAKE_SOURCEPATH is that the cmake
man page says:
USAGE
cmake [options] <path-to-source>
And that's the directory that I want to set. So I thought that it would
be understandable for people familiar with cmake.
Mira
> Ross
More information about the Openembedded-core
mailing list