[OE-core] [PATCHv2 1/2] Add wic support to generate rootfs image for uboot

[Anders Darander]

* Adrian Calianu <Adrian.Calianu at enea.com> [140616 15:19]:

> > As for the patch itself, it's huge and needs to be broken up into
> > smaller pieces.  In fact, it seems to be a combination of two
> > completely separate things at least - a new mechanism for creating a
> > rootfs from packages, and a new plugin for creating uboot partitions
> > (which just happens to use the output from the new packaging step.
> > So at minimum I think you need to break it up along the lines of
> > that functionality, and it would be good to break it up even further
> > e.g. 'Add a new do_pkg interface hook', 'Add an implementation of
> > do_pkg for ipk', 'Add a new source plugin for uboot partitions',
> > 'Add a new canned wks for a default uboot image', etc.  The more you
> > can break it up into logical chunks without going overboard, the
> > easier it is to review and apply/revert.
> [Adrian Calianu] I agree that there are two main features but the
> reason of not break it in small pieces now was to provide a fully
> functional patch for community to test it and be able to provide a
> feedback for this patch, since those features cannot be tested
> independently now.  So, is it acceptable to provide patches that
> cannot be tested?

Well, if you split this into two or more patches, and you then submit
this as a patch series, then I don't see how they couldn't be tested?

Remember, no one forces you to send single patches.

So I'd say, try to split them up. That'll make them easier to review,
comment on, and to test.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB