[OE-core] [PATCH v2] sanity.bbclass: support wildcards in SANITY_TESTED_DISTROS
Khem Raj
raj.khem at gmail.com
Mon Mar 3 18:17:38 UTC 2014
On Mon, Mar 3, 2014 at 6:37 AM, Olof Johansson <olof.johansson at axis.com> wrote:
> With this change, you can use shell like globbing expressions (as
> supported by Python's fnmatch) for entries in SANITY_TESTED_DISTROS.
> This makes it possible to say that, e.g. "all Debian 7 Wheezy releases
> are supported" with the entry "Debian-7.*".
I dont think its a good thing. We should be strict about it as we are.
otherwise it can end up
with bigger problems to save few typing words
>
> [YOCTO #5265]
>
> Signed-off-by: Olof Johansson <olof.johansson at axis.com>
> ---
> meta/classes/sanity.bbclass | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index bae010d..d79db8f 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -246,6 +246,8 @@ def check_connectivity(d):
> return retval
>
> def check_supported_distro(sanity_data):
> + from fnmatch import fnmatch
> +
> tested_distros = sanity_data.getVar('SANITY_TESTED_DISTROS', True)
> if not tested_distros:
> return
> @@ -255,12 +257,15 @@ def check_supported_distro(sanity_data):
> except Exception:
> distro = None
>
> - if distro:
> - if distro not in [x.strip() for x in tested_distros.split('\\n')]:
> - bb.warn('Host distribution "%s" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.' % distro)
> - else:
> + if not distro:
> bb.warn('Host distribution could not be determined; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.')
>
> + for supported in [x.strip() for x in tested_distros.split('\\n')]:
> + if fnmatch(distro, supported):
> + return
> +
> + bb.warn('Host distribution "%s" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.' % distro)
> +
> # Checks we should only make if MACHINE is set correctly
> def check_sanity_validmachine(sanity_data):
> messages = ""
> --
> 1.8.5.3
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
More information about the Openembedded-core
mailing list