[OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous at broadcom.com>

Andrey Belous abelous at broadcom.com
Tue Mar 4 23:11:00 UTC 2014


Yes I overwriting more  , but other variable already with ?= and allow to override them

-Andrey 

-----Original Message-----
From: Saul Wold [mailto:sgw at linux.intel.com] 
Sent: Tuesday, March 04, 2014 6:05 PM
To: Andrey Belous; openembedded-core at lists.openembedded.org
Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous at broadcom.com>

On 03/04/2014 12:40 PM, Andrey Belous wrote:
> Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value

The format of your commit message is backwards, you need to have a short 
message with the filename:

tclibc-uclibc: <short message>

<long message>

Signed-off-by: ....


Also this kind of change is distro specific and could be in your distro 
specific information, don;'t you need to override more of what's in here 
if you are using a prebuilt library?

Sau!

> ---
>   meta/conf/distro/include/tclibc-uclibc.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/include/tclibc-uclibc.inc b/meta/conf/distro/include/tclibc-uclibc.inc
> index 9245112..a4d8c39 100644
> --- a/meta/conf/distro/include/tclibc-uclibc.inc
> +++ b/meta/conf/distro/include/tclibc-uclibc.inc
> @@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc"
>   LIBCOVERRIDE = ":libc-uclibc"
>   OVERRIDES .= "${LIBCOVERRIDE}"
>
> -PREFERRED_PROVIDER_virtual/libc = "uclibc"
> +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"
>   PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv"
>   PREFERRED_PROVIDER_virtual/libintl ?= "gettext"
>   PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc"
>



More information about the Openembedded-core mailing list