[OE-core] [PATCH] kernel-yocto: Inspect remote branches with git ls-remote

Richard Purdie richard.purdie at linuxfoundation.org
Wed Mar 5 17:47:07 UTC 2014


On Wed, 2014-03-05 at 16:49 +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming at intel.com>
> 
> 'git branch' may use ANSI escape codes in its output (to provide colour)
> which doesn't play well with commands expecting pure plain text, e.g.
> 
>     fatal: '^[[31mmaster^[[m' is not a valid branch name.
> 
> Furthermore, the output of 'git branch' is subject to change and trying
> to parse it could potentially lead to breakage in the future.
> 
> Signed-off-by: Matt Fleming <matt.fleming at intel.com>
> ---
>  meta/classes/kernel-yocto.bbclass | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

My worry with this change is that it will cause the system to hit the
network. We specifically support builds from archives of the
repositories so I'd worry about using ls-remote like this :/.

Cheers,

Richard




More information about the Openembedded-core mailing list