[OE-core] [PATCH 5/6] lttng-modules: Fix 3.14 bio tracepoints
Tom Zanussi
tom.zanussi at linux.intel.com
Thu Mar 6 17:09:30 UTC 2014
From: Tom Zanussi <tom.zanussi at intel.com>
The mainline 3.14 commit 'block: Astract out bvec iterator' broke the
lttng-modules tracepoints. Fix them here.
Signed-off-by: Tom Zanussi <tom.zanussi at intel.com>
---
.../lttng/lttng-modules/bio-bvec-iter.patch | 156 +++++++++++++++++++++
meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb | 3 +-
2 files changed, 158 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/lttng/lttng-modules/bio-bvec-iter.patch
diff --git a/meta/recipes-kernel/lttng/lttng-modules/bio-bvec-iter.patch b/meta/recipes-kernel/lttng/lttng-modules/bio-bvec-iter.patch
new file mode 100644
index 0000000..d6c66e4
--- /dev/null
+++ b/meta/recipes-kernel/lttng/lttng-modules/bio-bvec-iter.patch
@@ -0,0 +1,156 @@
+Upstream-Status: Pending
+
+In 3.14, bi_sector and bi_size were moved into an iterator, thus
+breaking any tracepoints that still expect them in the bio. Fix up
+the lttng-module tracepoints to use the new scheme when the kernel
+version is >= 3.14.
+
+Signed-off-by: Tom Zanussi <tom.zanussi at intel.com>
+
+diff --git a/instrumentation/events/lttng-module/block.h b/instrumentation/events/lttng-module/block.h
+index f3b8bff..0a61543 100644
+--- a/instrumentation/events/lttng-module/block.h
++++ b/instrumentation/events/lttng-module/block.h
+@@ -341,9 +341,15 @@ TRACE_EVENT(block_bio_bounce,
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev ?
+ bio->bi_bdev->bd_dev : 0)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -385,14 +391,24 @@ TRACE_EVENT(block_bio_complete,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev->bd_dev)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
++
+ #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38))
+ tp_assign(error, error)
+ #else
+ tp_assign(error, 0)
+ #endif
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ ),
+
+ TP_printk("%d,%d %s %llu + %u [%d]",
+@@ -419,9 +435,15 @@ DECLARE_EVENT_CLASS(block_bio_merge,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev->bd_dev)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -485,9 +507,15 @@ TRACE_EVENT(block_bio_queue,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev->bd_dev)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -513,9 +541,15 @@ DECLARE_EVENT_CLASS(block_bio,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev ? bio->bi_bdev->bd_dev : 0)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -587,10 +621,17 @@ DECLARE_EVENT_CLASS(block_get_rq,
+
+ TP_fast_assign(
+ tp_assign(dev, bio ? bio->bi_bdev->bd_dev : 0)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio ? bio->bi_iter.bi_sector : 0)
++ tp_assign(nr_sector, bio ? bio->bi_iter.bi_size >> 9 : 0)
++ blk_fill_rwbs(rwbs, bio ? bio->bi_rw : 0,
++ bio ? bio->bi_iter.bi_size >> 9 : 0)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio ? bio->bi_sector : 0)
+ tp_assign(nr_sector, bio ? bio->bi_size >> 9 : 0)
+ blk_fill_rwbs(rwbs, bio ? bio->bi_rw : 0,
+ bio ? bio->bi_size >> 9 : 0)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -759,9 +800,15 @@ TRACE_EVENT(block_split,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev->bd_dev)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(new_sector, new_sector)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(new_sector, new_sector)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_memcpy(comm, current->comm, TASK_COMM_LEN)
+ ),
+
+@@ -805,11 +852,19 @@ TRACE_EVENT(block_remap,
+
+ TP_fast_assign(
+ tp_assign(dev, bio->bi_bdev->bd_dev)
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0))
++ tp_assign(sector, bio->bi_iter.bi_sector)
++ tp_assign(nr_sector, bio->bi_iter.bi_size >> 9)
++ tp_assign(old_dev, dev)
++ tp_assign(old_sector, from)
++ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_iter.bi_size)
++#else /* #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ tp_assign(sector, bio->bi_sector)
+ tp_assign(nr_sector, bio->bi_size >> 9)
+ tp_assign(old_dev, dev)
+ tp_assign(old_sector, from)
+ blk_fill_rwbs(rwbs, bio->bi_rw, bio->bi_size)
++#endif /* #else #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) */
+ ),
+
+ TP_printk("%d,%d %s %llu + %u <- (%d,%d) %llu",
diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb b/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
index 79d9382..8883094 100644
--- a/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
+++ b/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
@@ -17,7 +17,8 @@ PV = "2.4.0"
COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.4 \
- file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch"
+ file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch \
+ file://bio-bvec-iter.patch"
export INSTALL_MOD_DIR="kernel/lttng-modules"
export KERNEL_SRC="${STAGING_KERNEL_DIR}"
--
1.8.3.1
More information about the Openembedded-core
mailing list