[OE-core] [PATCH] python3: Add ptest support

[Paul Barker]

On 11 March 2014 21:27, Tudor Florea <Tudor.Florea at enea.com> wrote:
>
>
>>On 10 March 2014 18:15, Saul Wold <sgw at linux.intel.com> wrote:
>>> On 03/06/2014 04:54 PM, Paul Barker wrote:
>>>>
>>>> A run-ptest script written in python is added which defines a new
>>>> TestRunner
>>>> subclass which prints test results in the required ptest format and then
>>>> executes python's built-in testsuite using this new TestRunner subclass.
>>>> <snip>
>>>
>>> Seems like there is an issue with the multi-lib build.
>>>
>>> ERROR: QA Issue: lib32-python3: Files/directories were installed but not
>>> shipped
>>>   /usr/lib/python3
>>>   /usr/lib/python3/ptest
>>> NOTE: recipe lib32-pulseaudio-4.0-r0: task do_package_write_rpm: Started
>>>
>>> Sau!
>>>
>>>
>>>
>>>> +# This must come after inherit ptest for the override to take effect
>>>> +do_install_ptest() {
>>>> +    install -m 0755 -d ${D}/${libdir}/python3/ptest
>>>> +    install -m 0755 ${S}/../run-ptest ${D}/${libdir}/${PN}/ptest
>>>> +}
>>
>> Should I be using something other than ${libdir} here? I can see
>> ${PTEST_PATH} used in the do_install_ptest function for python2,
>> should I be using that instead?
>>
>> As I think I noted elsewhere, this is the first ptest related patch
>> I've done so I don't really know much beyond what's documented at
>> https://wiki.yoctoproject.org/wiki/Ptest.
>
> I think you may have to add a line like
> FILES_${PN} += "/usr/lib/python3/ptest"
> in the recipe (meta/recipes-devtools/python/python3_3.3.3.bb).

No, this belongs in the -ptest package. I just don't know what I'm doing wrong.

> ${PTEST_PATH} might be different than the above due to the use of suffix  ${PYTHON_MAJMIN}.
> Alternatively you might they to install ptest stuff here: ${D}${libdir}/python${PYTHON_MAJMIN}

I think the path should be based on the package name (python3), not on
an internal identifier.

Thanks,

-- 
Paul Barker

Email: paul at paulbarker.me.uk
http://www.paulbarker.me.uk