[OE-core] [PATCH 6/6] patch.bbclass: do_patch: unset TMPDIR from environment

[Chris Larson]

On Thu, Mar 13, 2014 at 9:54 AM, Burton, Ross <ross.burton at intel.com> wrote:

> On 13 March 2014 16:46, Burton, Ross <ross.burton at intel.com> wrote:
> > On 11 March 2014 17:08, Robert Yang <liezhi.yang at windriver.com> wrote:
> >> We need unset it after we use it, otherwise it would affect the env
> >> after we run "bb.build.exec_func('do_patch', d)", and will cause
> >> unexpected errors.
> >
> > This assignment has been there since October 2012, so what are the
> > problems that this causes?
>
> So what bothers me about this (and the original patch) is that TMPDIR
> has special meaning to bitbake and the conflict with patch's temporary
> directory is unfortunate.  Maybe a better solution is to change
> meta/lib/oe/patch.py to set TMPDIR when invoking patch so the changed
> TMPDIR is constrained to the patch process and nothing else.


That sounds like a clean approach to me.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140313/8cec5ee9/attachment-0002.html>