[OE-core] [PATCH V2 1/1] dbus: fix a hard dependency about dbus-ptest

Burton, Ross ross.burton at intel.com
Tue Mar 18 15:15:23 UTC 2014


On 18 March 2014 07:11, Chong Lu <Chong.Lu at windriver.com> wrote:
> +PACKAGES += "dbus-ptest"

This should be conditional on DISTRO_FEATURES containing ptest.

> +ALLOW_EMPTY_${PN}-ptest = "1"
> +RDEPENDS_dbus-ptest = "dbus-test-ptest"

Please be consistent with the use of dbus-ptest and ${PN}-ptest.

> +RPROVIDES_dbus-ptest = "${@base_contains('DISTRO_FEATURES', 'ptest', '', 'dbus-test-ptest', d)}"

This line took me a minute to understand and won't be needed if the
PACKAGES addition is conditional.

Ross



More information about the Openembedded-core mailing list