[OE-core] [PATCH 0/6 V3] refactor the archiver*.bbclass

[Paul Eggleton]

Hi Robert,

On Wednesday 12 March 2014 01:08:18 Robert Yang wrote:
> === V3:
> * Do the unpack, patch and configure in another WORKDIR as RP and Ross
>   suggested, so that it would not affact the default build dependencies,
>   thanks for Ross' prototype.
> * Don't archive the logs (temp/log.do*), mainly because of:
>   - We can easily get the log via reset the T rather than use the
>     archiver.
>   - If we need archive the logs, we must let the task to run as the last
>     one, but it's hard to do this.
> 
> === V2:
> * Fix the warning between different machines which is reported by Martin
> * Fix the error when the archiver.bbclass is not inherited but
>   ARCHIVER_MODE[type] = "srpm" is set, reported by Ross.
> * Fix the archiving for gcc staff which uses the shared source according
>   to the recently changes of prefuncs and postfuncs in bitbake, so it only
>   works well with bitbake's up to date master branch, if we want to backport
> it, we also need backport the pre/postfuncs related patches.
> 
> === V1:
> * The archive*.bbclass didn't work, and there were a few problems, for
>   example:
>   1) There were a few duplicated code
>   2) There was no src_dir.org (or orig), but the diff command still use
>      it, and it is not easy to fix this issue if we don't change a lot
>      of the code.
>   3) It didn't archive the source for the native or gcc
>   4) The work flow is not very well
>   5) The "subprocess.call('fakeroot cp xxxx'" should be removed
>   6) And others ...
> 
> * So that we have to refactor it, the benefits are:
>   1) Fix the problems and make it work well.
>   2) Reduce more than 400 lines in total.
>   3) Make it easy to use.
> 
> // Robert
> 
> 
> The following changes since commit 23f7decb84922a3467c5b10b013e66596926b5cf:
> 
>   .templateconf: New file for customized template defaults (2014-03-11
> 08:11:07 -0700)
> 
> are available in the git repository at:
> 
>   git://git.openembedded.org/openembedded-core-contrib rbt/archiver_v3
>  
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/
> archiver_v3
> 
> Robert Yang (6):
>   classes/archive*.bbclass: remove archive-*-source.bbclass
>   archiver.bbclass: refactor it
>   package_rpm.bbclass: archive the source to srpm package
>   archiver.bbclass: move a few code to copyleft_compliance.bbclass
>   local.conf.sample.extended: update for the archiver

I've had a look at this series - great work on the refactoring and cleanup! 
There were a couple of things I noticed, I've replied to the individual 
patches.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre