[OE-core] [poky] [RFC PATCH v2 0/3] Master image generation and testing

[Paul Eggleton]

Hi Stefan,

On Monday 17 March 2014 17:42:13 Stefan Stanacar wrote:
> This is what I currently use for doing automated deployment
> for a genericx86-64 image. More details on the commit
> messages. There is nothing particular to genericx86-64,
> it should work on any EFI-enabled device with gummiboot as bootloader.
> 
> Changes since v2:
>   - droped the kernel options patch, the required options are now in the
> default config fragments. You still neeed to build with an updated SRCREV
> though, as the kernel recipes haven't picked up the changes yet.
> (SRCREV_meta_pn-linux-yocto = "${AUTOREV}" in local.conf)
>   - impove a bit the master image recipe (inherit core-image and add to
> IMAGE_INSTALL instead of overwriting IMAGE_INSTALL, that ensures we pick up
> the correct modules, as core-image brings in packagegroup-base-extended)
>   - tweaks and fixes for GenericEfi - I did a complete test run for a NUC
> device connected to a web power strip. The powercontrol command is an
> expect script that does ssh on a device which controls the power strip
> (this is particular to a network setup that I can't control). It still
> works for the no power command available case.
> 
> Also see YB#1596 and it's sub-bug #5614 for a bit of background.
> Any comments, questions, most welcome.
> 
> Cheers,
> Stefan
> 
> 
> Please review the following changes for suitability for inclusion. If you
> have any objections or suggestions for improvement, please respond to the
> patches. If you agree with the changes, please provide your Acked-by.
> 
> The following changes since commit 92155fde2079251739f455bca599a52cd21ef12b:
> 
>   bitbake: runqueue: Don't error if we never setup workers (2014-03-17
> 15:04:46 +0000)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib stefans/masterimage
>  
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=stefans/masterimag
> e

Looks good. Some review comments:

* Is all of packagegroup-core-full-cmdline really needed for the master image 
or just some specific utilities that it pulls in?

* Could we have TEST_POWERCONTROL_EXTRA_ARGS so that TEST_POWERCONTROL_CMD can 
be set generically for the user's setup and extra machine-specific arguments 
(such as serial port numbers or other identifiers) can be set easily on a per-
machine basis if needed?

* I wonder if TEST_DEPLOY_CMDS should be lower-case since it would be most 
easily defined as a function i.e. testimage_deploy_cmds() { ... } than a 
traditional variable. (Reading it is exactly the same i.e. d.getVar().)

All of this seems generic enough that I think the better place for it would be 
OE-Core rather than meta-yocto-bsp. If you could apply these changes on top of 
OE-Core and send v3 to the OE-Core mailing list that would be great.

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre