[OE-core] [PATCH] Add init script (sysv) support for busybox's ntpd

[Otavio Salvador]

On Thu, Mar 20, 2014 at 9:16 AM, Laszlo Papp <lpapp at kde.org> wrote:
> On Thu, Mar 20, 2014 at 11:59 AM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>> On Thu, Mar 20, 2014 at 8:34 AM, Laszlo Papp <lpapp at kde.org> wrote:
>>> On Thu, Mar 20, 2014 at 11:22 AM, Koen Kooi <koen at dominion.thruhere.net> wrote:
>>>>
>>>> Op 20 mrt. 2014, om 11:45 heeft Burton, Ross <ross.burton at intel.com> het volgende geschreven:
>>>>
>>>>> On 20 March 2014 03:26, Laszlo Papp <lpapp at kde.org> wrote:
>>>>>> +PEER=127.0.0.1
>>>>>
>>>>> That doesn't seem like a very useful default.  We also can't use the
>>>>> NTP pool by default, so this should copy the behaviour of the ntpd
>>>>> package in meta-networking and default to no peers, and not start if
>>>>> none are specified.
>>>>
>>>> And the initscript is missing LSB headers.
>>>
>>> Just like the other similar scripts.
>>
>> This does not mean we ought to make the problem worse so add it for
>> new ones. If you are in good mood, send a fix for the others too ;)
>
> I do not think this is a problem. Could you please point out what
> functionality it breaks? Send patches for the others, and I will make
> this cosmetic change for this one, too. Consistency is more important
> than a mess of different styles, especially when it comes to cosmetic
> changes like this.

Koen and I think it is important. So consider this my NACK for the patch as is.

You are free to do whatever you want.

> That said, Ross had a good point - although that is not critical
> either, and since everyone is overriding the default, it could work
> without that - , so I will update that one.

Better.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750