[OE-core] [PATCH] Add init script (sysv) support for busybox's ntpd

Khem Raj raj.khem at gmail.com
Thu Mar 20 16:42:14 UTC 2014


On Thu, Mar 20, 2014 at 5:16 AM, Laszlo Papp <lpapp at kde.org> wrote:
>>>> And the initscript is missing LSB headers.
>>>
>>> Just like the other similar scripts.
>>
>> This does not mean we ought to make the problem worse so add it for
>> new ones. If you are in good mood, send a fix for the others too ;)
>
> I do not think this is a problem. Could you please point out what
> functionality it breaks?

it would be not groked by systemd e.g. folks use sysvinit, systemd,
upstart with OE
moreover we do have aspirations to come closer to lsb
there are lsb images that some distros produce. There might be
existing scripts which
dont have lsb headers however those are wrong examples to adhere to
when generating brand
new scripts.

 Send patches for the others, and I will make
> this cosmetic change for this one, too.

having said above why is that a condition for you to make your patch better ?

Consistency is more important
> than a mess of different styles, especially when it comes to cosmetic
> changes like this.

lets say we are moving towards consistency one after another its not
going to happen overnight
but each contribution in right direction helps.



More information about the Openembedded-core mailing list