[OE-core] [PATCH v2] runqemu: Add option for custom BIOS directory

[Ricardo Neri]

On Thu, 2014-03-20 at 12:35 -0700, Ricardo Neri wrote:
> Add support to specify a directory for custom BIOS, VGA BIOS and
> keymaps as supported by qemu (-L option). Even though this can be
> done through qemuparams, having this option provides better user
> experience by not having to specify a long and cluttered path along
> with other qemuparams that the user might want to specify.
> 
> This new options assumes first that the path provided is relative to
> OECORE_NATIVE_SYSROOT and will check whether it exists before proceeding.
> If not, it will treat the provided path as absolute. This provides
> the user flexibility to use BIOS binaries generated inside or outside
> the OE build environment.
> 
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon at linux.intel.com>
> ---
>  scripts/runqemu | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 619ffb6..b1d2d1a 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -149,6 +149,9 @@ while true; do
>              SCRIPT_KERNEL_OPT="$SCRIPT_KERNEL_OPT console=ttyS0"
>              SERIALSTDIO="1"
>              ;;
> +	"biosdir="*)
> +            CUSTOMBIOSDIR="${arg##biosdir=}"
> +	    ;;
>          "qemuparams="*)
>              SCRIPT_QEMU_EXTRA_OPT="${arg##qemuparams=}"
>  
> @@ -489,5 +492,21 @@ if [ ! -f "$INTERNAL_SCRIPT" -o ! -r "$INTERNAL_SCRIPT" ]; then
>  INTERNAL_SCRIPT=`which runqemu-internal`
>  fi
>  
> +# Specify directory for BIOS, VGA BIOS and keymaps
> +if [ ! -z "$CUSTOMBIOSDIR" ]; then
> +    if [ -d "$OECORE_NATIVE_SYSROOT/$CUSTOMBIOSDIR" ]; then
> +        echo "Assuming biosdir is $OECORE_NATIVE_SYSROOT/$CUSTOMBIOSDIR"
> +        SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -L $OECORE_NATIVE_SYSROOT/$CUSTOMBIOSDIR"
> +    else
> +        if [ ! -d "$CUSTOMBIOSDIR" ]; then
> +            echo "Custom BIOS directory not found. Tried: $CUSTOMBIOSDIR"
> +            echo "and $OECORE_NATIVE_SYSROOT/$CUSTOMBIOSDIR"
> +            exit 1;
> +        fi
> +        echo "Assuming biosdir is $CUSTOMBIOSDIR"
> +        SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -L $CUSTOMBIOSDIR"
> +    fi
> +fi
> +
>  . $INTERNAL_SCRIPT
>  exit $?

Hi!

I just wanted to check if there are comments about this patch.

BR,
Ricardo