[OE-core] [PATCH 04/13] trace-cmd: remove usage of FILESPATH

[Martin Jansa]

On Wed, May 07, 2014 at 11:19:50PM +0200, Petter Mabäcker wrote:
> Fixes [YOCTO #4497]
> 
> Usage of FILESPATH is discouraged, since it can make recipes harder to
> bbappend. All current patches in trace-cmd are shared, move them to
> files instead, since it's included in base FILESPATH.

FWIW: using "files" is also a bit discouraged, because it's searched
last, so the lookup takes longer (trying ~30 different directories a lot
more with more OVERRIDES).

I don't know what's worse.

> Signed-off-by: Petter Mabäcker <petter at technux.se>
> ---
>  .../{trace-cmd => files}/addldflags.patch          |    0
>  .../blktrace-api-compatibility.patch               |    0
>  .../kernelshark-fix-syntax-error-of-shell.patch    |    0
>  .../{trace-cmd => files}/make-docs-optional.patch  |    0
>  ...dd-checks-for-invalid-pointers-to-fix-seg.patch |    0
>  ...o-not-call-stop_threads-if-doing-latency-.patch |    0
>  ...etting-plugin-to-nop-clears-data-before-i.patch |    0
>  .../trace-cmd-fix-syntax-error-of-shell.patch      |    0
>  meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |    2 --
>  9 files changed, 2 deletions(-)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/addldflags.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/blktrace-api-compatibility.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/kernelshark-fix-syntax-error-of-shell.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/make-docs-optional.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch (100%)
>  rename meta/recipes-kernel/trace-cmd/{trace-cmd => files}/trace-cmd-fix-syntax-error-of-shell.patch (100%)
> 
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/addldflags.patch b/meta/recipes-kernel/trace-cmd/files/addldflags.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/addldflags.patch
> rename to meta/recipes-kernel/trace-cmd/files/addldflags.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/blktrace-api-compatibility.patch b/meta/recipes-kernel/trace-cmd/files/blktrace-api-compatibility.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/blktrace-api-compatibility.patch
> rename to meta/recipes-kernel/trace-cmd/files/blktrace-api-compatibility.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/files/kernelshark-fix-syntax-error-of-shell.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> rename to meta/recipes-kernel/trace-cmd/files/kernelshark-fix-syntax-error-of-shell.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/make-docs-optional.patch b/meta/recipes-kernel/trace-cmd/files/make-docs-optional.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/make-docs-optional.patch
> rename to meta/recipes-kernel/trace-cmd/files/make-docs-optional.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/files/trace-cmd-fix-syntax-error-of-shell.patch
> similarity index 100%
> rename from meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> rename to meta/recipes-kernel/trace-cmd/files/trace-cmd-fix-syntax-error-of-shell.patch
> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> index d61097d..291c068 100644
> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> @@ -21,8 +21,6 @@ S = "${WORKDIR}/git"
>  
>  EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
>  
> -FILESPATH = "${FILE_DIRNAME}/trace-cmd"
> -
>  do_install() {
>  	oe_runmake CC="${CC}" AR="${AR}" prefix="${prefix}" DESTDIR="${D}" install_gui
>  	rm -rf ${D}${datadir}/trace-cmd
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140508/ae19f38b/attachment-0002.sig>