[OE-core] [PATCH] mesa-demos: Specify the lib dir properly.

Drew Moseley drew at moseleynet.net
Mon May 12 22:26:29 UTC 2014


On May 12, 2014, at 5:42 PM, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
> On Mon, 2014-05-12 at 16:10 -0400, \Drew Moseley wrote:
>> From: Drew Moseley <drew_moseley at mentor.com>
>> 
>> Use STAGING_EXECPREFIXDIR to specify the location of glut
>> header files and libs rather than STAGING_LIBDIR.
>> 
>> Also revert the previous unneeded change to glut.patch.
>> 
>> Signed-off-by: Drew Moseley <drew_moseley at mentor.com>
>> ---
>> meta/recipes-graphics/mesa/mesa-demos/glut.patch |    2 +-
>> meta/recipes-graphics/mesa/mesa-demos_8.1.0.bb   |    2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Is this change multilib safe?
> 
> It looks to me like this hardcodes "lib" and things like "lib64" or
> "lib32" would be an issue since it wouldn't honour $libdir?
> 
> Cheers,
> 
> Richard

Sort of.  This is essentially putting the code back to what it was yesterday
which was hardcoded to /lib.  It doesn't affect Yocto builds since the
"--sysroot" option makes the directories specified here redundant.  I have
verified the libraries are properly located even when installed in usr/lib64.

Ultimately this should probably be cleaned up in the upstream mesa-demos
by adding a "--with-glut-includes" and "--with-glut-libs" or some such but
this is at least less broken than it was before   Previously setting "glut"
in the packageconfig would pass "--with-glut" to configure resulting in
the build failure:

> ../../x86_64-mel-linux-libtool: line 6012: cd: yes/lib: No such file or directory
> x86_64-mel-linux-libtool: link: cannot determine absolute directory name of `yes/lib'
> make[2]: *** [libutil.la] Error 1

Drew




More information about the Openembedded-core mailing list