[OE-core] [PATCH] libusb1: Update to 1.0.18

[Andrea Adami]

On Fri, May 16, 2014 at 8:47 PM, Jacob Kroon <jacob.kroon at gmail.com> wrote:
> On Fri, May 16, 2014 at 7:14 PM, Saul Wold <sgw at linux.intel.com> wrote:
>>
>> On 05/16/2014 05:16 AM, Jacob Kroon wrote:
>>>
>>> On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon at gmail.com>
>>> wrote:
>>>
>>>> Hello Saul,
>>>>
>>>>
>>>> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw at linux.intel.com> wrote:
>>>>
>>>>> Signed-off-by: Saul Wold <sgw at linux.intel.com>
>>>>> ---
>>>>>   .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch      |
>>>>> 0
>>>>>   .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} |
>>>>> 7
>>>>> ++-----
>>>>>   2 files changed, 2 insertions(+), 5 deletions(-)
>>>>>   rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>>>>> libusb1}/obsolete_automake_macros.patch (100%)
>>>>>   rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>>>>> libusb1_1.0.18.bb} (78%)
>>>>>
>>>>> diff --git
>>>>>
>>>>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>> similarity index 100%
>>>>> rename from
>>>>>
>>>>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>> rename to
>>>>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>> diff --git
>>>>> a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
>>>>> libusb1_1.0.18.bb
>>>>> similarity index 78%
>>>>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>> index d57425b..c64f1db 100644
>>>>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>>>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>>>
>>>>>   BBCLASSEXTEND = "native nativesdk"
>>>>>
>>>>> -PR = "r1"
>>>>> -
>>>>>   SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>>>> -           file://obsolete_automake_macros.patch \
>>>>>             "
>>>>>
>>>>
>>>> That patch is still in git, maybe it should be removed as well ?
>>>>
>>>>
>>> Also, I think it needs to be added a PACKAGECONFIG for "udev", otherwise
>>> I
>>> get a build failure when I generate an SDK on my system,
>>> configure script can't find udev although it was requested.
>>>
>>
>>> Something like the patch below does the trick for me:
>>>
>> I am supprised you did not see a circular dependency with udev -> libusb
>> -> udev, I think we need to disable-udev as default and if there is a need
>> for a libusb with udev support we will have to create a new recipe possibly
>> to build it after udev is built.
>>
>
> With the patch applied, I wiped my sysroots and did a "cleansstate libusb1
> udev", and then rebuilt both successfully with no warning
> about circular dependency. Maybe I'm not hitting the error since I have
> "systemd" in DISTRO_FEATURES, so it's actually systemd that is the udev
> provider.
>
>> Thoughts here?
>>
>> Sau!
>>
>>

Yes, building sysvinit I get the failure:
| checking operating system... Linux
| checking for library containing clock_gettime... none required
| checking libudev.h usability... no
| checking libudev.h presence... no
| checking for libudev.h... no
| configure: error: "udev support requested but libudev not installed"
| Configure failed. The contents of all config.log files follows to
aid debugging
| ERROR: oe_runconf failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_configure (log file is located at
/oe/oe-core/build/tmp-eglibc/
work/armv4-oe-linux-gnueabi/libusb1/1.0.18-r0/temp/log.do_configure.23838)
ERROR: Task 1803
(/oe/oe-core/meta/recipes-support/libusb/libusb1_1.0.18.bb,
do_configure) failed with exit code '1'

Andrea


>>
>>> --- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> @@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>
>>>   BBCLASSEXTEND = "native nativesdk"
>>>
>>> -SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>> -          "
>>> +SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
>>>
>>>   SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
>>>   SRC_URI[sha256sum] =
>>> "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
>>>
>>> +PACKAGECONFIG ?= "udev"
>>> +PACKAGECONFIG_class-native = ""
>>> +PACKAGECONFIG_class-nativesdk = ""
>>> +
>>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>>> +
>>>   S = "${WORKDIR}/libusb-${PV}"
>>>
>>>   inherit autotools pkgconfig
>>>
>>> If this looks good I can submit a proper patch for it.
>>>
>>> /Jacob
>>>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>