[OE-core] [PATCH] oeqa/controllers/beaglebonetarget.py: add conditions for files copied to /boot

Anders Darander anders at chargestorm.se
Tue May 27 06:46:29 UTC 2014


* Corneliu Stoicescu <corneliux.stoicescu at intel.com> [140526 15:23]:

> Sometimes the rootfs archive contains the kernel file
> (core-image-full-cmdline) or the dtbs files (core-image-sato). Adding
> verification to add them if they don't allready exist.

> Without this, the first condition would fail and the image deploy task would stop.

What failure and errors are you seeing?

> -                '[ ! -e /mnt/testrootfs/boot/uImage ] && cp ~/test-kernel /mnt/testrootfs/boot/uImage',
> +                'if [ ! -e /mnt/testrootfs/boot/uImage ]; then cp ~/test-kernel /mnt/testrootfs/boot/uImage; fi',

It might be that I've had no coffee yet, but I can't see what difference
your change is making (apart from being more verbose)?

The original code checks for the existance of
/mnt/testrootfs/boot/uImage, negates the result and copies the
test-kernel if the negated result is true, i.e. if
/mnt/testrootfs/boot/uImage doesn't exist, copy the test-kernel.

> -            self.deploy_cmds.append('[ ! -e /mnt/testrootfs/boot/{0} ] && cp ~/{0} /mnt/testrootfs/boot/'.format(dtbfn))
> +            self.deploy_cmds.append('if [ ! -e /mnt/testrootfs/boot/{0} ]; then cp ~/{0} /mnt/testrootfs/boot/'.format(dtbfn) + '; fi')

See above...

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB



More information about the Openembedded-core mailing list