[OE-core] [PATCH] oeqa/controllers/beaglebonetarget.py: add conditions for files copied to /boot

[Anders Darander]

* Stoicescu, CorneliuX <corneliux.stoicescu at intel.com> [140527 09:02]:
> > -----Original Message-----
> > From: Anders Darander [mailto:anders at chargestorm.se]
> > * Corneliu Stoicescu <corneliux.stoicescu at intel.com> [140526 15:23]:

> > > Sometimes the rootfs archive contains the kernel file
> > > (core-image-full-cmdline) or the dtbs files (core-image-sato). Adding
> > > verification to add them if they don't allready exist.

> > > Without this, the first condition would fail and the image deploy task would
> > stop.

> > What failure and errors are you seeing?


> '[ ! -e /mnt/testrootfs/boot/uImage ] && cp
> ~/test-kernel/mnt/testrootfs/boot/uImage' returns exit code 1 if the
> first condition is not met, and thus the deploy task fails. My version
> would return exit code 0 weather or not the first condition is met. 

Oh, that's right. If /mnt/testrootfs/boot/uImage do exist, we'll have an
exit code of 1... -ENOCOFFE like I said!

However, then I think that the commit message ought to be changed.
Reading the message, it sounds as you're adding a check to add uImage if
it doesn't exist. Rather, you're modifying the existing check to
gracefully handle the case where uImage already exists.

Could you update the commit message to better reflect the intention with
the change?

> We could also modify the way the commands are run to ignore that exit
> code but that would involve more changes, many of them not needed or
> expected by other commands and/or target controllers.

No, the above change is fine. We should error out if something goes
wrong, so I'd be against changing the way to run commands.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB