[OE-core] [PATCH 1/1] systemd: add network config while networkd supported

[Enrico Scholz]

Hongxu Jia <hongxu.jia-CWA4WttNNZF54TAoqtyWWQ at public.gmane.org> writes:

> While networkd supported, we add network config which starts
> dhcp by default.
> ...
> +++ b/meta/recipes-core/systemd/systemd/oe-core.network
> @@ -0,0 +1,8 @@
> +[Match]
> +Name=eth*
> +
> +[Network]
> +DHCP=v4
> +
> +[DHCPv4]
> +UseHostname=false

IMO, this is too much a target specific customization.  DHCP is not
used everywhere; it might conflict with NFS rootfs, there are different
preferences for the DHCP options (UseDomains, VendorClassIdentifier,
CriticalConnection, ...).

It would be better to place this confguration into a separate recipe.


> +		install -m 0755 ${WORKDIR}/oe-core.network ${D}${sysconfdir}/systemd/network

You should name this file like '50-oe-core.network' to make it easier to
override it.


Enrico