[OE-core] [PATCH 4/4] postinst-intercept: rename recipe for nativesdk only

Andreas Müller schnitzeltony at googlemail.com
Fri Nov 7 09:28:48 UTC 2014


On Fri, Nov 7, 2014 at 9:27 AM, Hongxu Jia <hongxu.jia at windriver.com> wrote:
> On 11/07/2014 04:18 PM, Andreas Müller wrote:
>>
>> On Fri, Nov 7, 2014 at 8:57 AM, Hongxu Jia <hongxu.jia at windriver.com>
>> wrote:
>>>
>>> The recipe postinst-intercept is only used for nativesdk, so we rename
>>> it from postinst-intercept to nativesdk-postinst-intercept.
>>>
>>> It avoids unnecessary build of postinst-intercept.
>>>
>>> [YOCTO #6937]
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
>>> ---
>>>   ...ostinst-intercept_1.0.bb => nativesdk-postinst-intercept_1.0.bb} | 6
>>> +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>   rename
>>> meta/recipes-devtools/postinst-intercept/{postinst-intercept_1.0.bb =>
>>> nativesdk-postinst-intercept_1.0.bb} (83%)
>>>
>>> diff --git
>>> a/meta/recipes-devtools/postinst-intercept/postinst-intercept_1.0.bb
>>> b/meta/recipes-devtools/postinst-intercept/nativesdk-postinst-intercept_1.0.bb
>>> similarity index 83%
>>> rename from
>>> meta/recipes-devtools/postinst-intercept/postinst-intercept_1.0.bb
>>> rename to
>>> meta/recipes-devtools/postinst-intercept/nativesdk-postinst-intercept_1.0.bb
>>> index 41b9a6e..7dc45c6 100644
>>> --- a/meta/recipes-devtools/postinst-intercept/postinst-intercept_1.0.bb
>>> +++
>>> b/meta/recipes-devtools/postinst-intercept/nativesdk-postinst-intercept_1.0.bb
>>> @@ -2,12 +2,12 @@ SUMMARY = "Postinstall scriptlets"
>>>   LICENSE = "MIT"
>>>   LIC_FILES_CHKSUM =
>>> "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>>>
>>> -FILES_${PN}_append_class-nativesdk = " ${datadir}/postinst-intercepts/*"
>>> +FILES_${PN}_append = " ${datadir}/postinst-intercepts/*"
>>>
>>>   do_configure[noexec] = "1"
>>>   do_compile[noexec] = "1"
>>>
>>> -do_install_append_class-nativesdk() {
>>> +do_install() {
>>>          install -d ${D}${datadir}/postinst-intercepts
>>>          install -m 755
>>> ${COREBASE}/scripts/postinst-intercepts/postinst_intercept
>>> ${D}${datadir}/postinst-intercepts/
>>>          install -m 755
>>> ${COREBASE}/scripts/postinst-intercepts/update_font_cache
>>> ${D}${datadir}/postinst-intercepts/
>>> @@ -15,5 +15,5 @@ do_install_append_class-nativesdk() {
>>>          install -m 755
>>> ${COREBASE}/scripts/postinst-intercepts/update_pixbuf_cache
>>> ${D}${datadir}/postinst-intercepts/
>>>   }
>>>
>>> -BBCLASSEXTEND = "nativesdk"
>>> +inherit nativesdk
>>>   INHIBIT_DEFAULT_DEPS = "1"
>>> --
>>> 1.9.1
>>>
>> is it possible that the commit message does not match to the patch?
>
>
> You mean the patch doesn't match with cover letter or the patch's commit
> message?
>
> Rename it is to avoid to install postinst-intercept, that will let build
> postinst-intercept
> invalid at parsing time rather than failed at image's do_root.
>
> //Hongxu
>
>
Aargh - I did not read the patch properly - should learn not to write
coffee-less comments

Andreas



More information about the Openembedded-core mailing list